[chore] Update otel, fix tests #35701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/githubgen
cmd/opampsupervisor
cmd/telemetrygen
djaglowski
requested review from
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole,
atoulme,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
songy23,
tigrannajaryan,
mwear and
jsuereth
as code owners
songy23
reviewed
Oct 8, 2024
| @@ -546,7 +546,7 @@ func TestFilterMetricProcessorTelemetry(t *testing.T) { | |||
| IsMonotonic: true, | |||
| DataPoints: []metricdata.DataPoint[int64]{ | |||
| { | |||
| Value: 4, | |||
| Value: 5, | |||
There was a problem hiding this comment.
Out of curiosity: where is this from? Is it intentional?
There was a problem hiding this comment.
I believe this is because of open-telemetry/opentelemetry-collector#11360, right?
There was a problem hiding this comment.
It is intentional, see open-telemetry/opentelemetry-collector#11360 (comment)
songy23
approved these changes
Oct 8, 2024
evan-bradley
approved these changes
Oct 8, 2024
atoulme
approved these changes
Oct 8, 2024
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Dan Jaglowski <[email protected]>
jmichalek132
pushed a commit
to jmichalek132/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Dan Jaglowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.